Skip to content

fix: signed-shift UB in SLH-DSA base_2b digest accumulator #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkAtwood wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix: signed-shift UB in SLH-DSA base_2b digest accumulator #10917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion wolfcrypt/src/wc_slhdsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,7 +1709,10 @@ static void slhdsakey_base_2b(const byte* x, byte b, byte outLen, word16* baseb)
int j;
int i = 0;
int bits = 0;
int total = 0;
/* total accumulates unmasked via << 8 and must be unsigned: a signed
* type overflows from the 4th consumed byte (UB). High bits are
* discarded by mask, so the output is unaffected. */
word32 total = 0;
word16 mask = (word16)((1 << b) - 1);

for (j = 0; j < outLen; j++) {
Expand Down
Loading