Regenerate armasm after scripts#625#10916
Open
mattia-moffa wants to merge 1 commit into
Open
Conversation
mattia-moffa
force-pushed
the
20260715-armasm-fix-625
branch
from
ae80fe4 to
06a2103
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR regenerates several ARM Thumb-2 inline-assembly “*_asm_c.c” sources after an upstream armasm generator fix (wolfssl/scripts#625), primarily adjusting argument handling when WOLFSSL_NO_VAR_ASSIGN_REG is in effect and normalizing operand usage inside the asm blocks.
Changes:
- Updated SHA3, Poly1305, ML-KEM, and ChaCha Thumb-2 inline asm wrappers to support the
WOLFSSL_NO_VAR_ASSIGN_REGconfiguration by marshalling arguments through a localL_asm_argsarray. - Converted many memory operands from named-input constraints (e.g.,
%[state]) to fixed-register addressing (e.g.,[r0, #offset]) after explicitly loading arguments intor0..rN. - Adjusted inline-asm operand lists and clobber lists accordingly for both
WOLFSSL_NO_VAR_ASSIGN_REGand non-WOLFSSL_NO_VAR_ASSIGN_REGbuilds.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfcrypt/src/port/arm/thumb2-sha3-asm_c.c | Regenerated SHA3 Thumb-2 asm wrapper to load args into r0/r1 under WOLFSSL_NO_VAR_ASSIGN_REG and use fixed-register addressing. |
| wolfcrypt/src/port/arm/thumb2-poly1305-asm_c.c | Regenerated Poly1305 Thumb-2 asm wrappers to marshal args via L_asm_args under WOLFSSL_NO_VAR_ASSIGN_REG and update register usage/clobbers. |
| wolfcrypt/src/port/arm/thumb2-mlkem-asm_c.c | Regenerated ML-KEM Thumb-2 asm wrappers to use L_asm_args marshalling under WOLFSSL_NO_VAR_ASSIGN_REG and fixed-register addressing. |
| wolfcrypt/src/port/arm/thumb2-chacha-asm_c.c | Regenerated ChaCha Thumb-2 asm wrappers to marshal args via L_asm_args under WOLFSSL_NO_VAR_ASSIGN_REG and shift to fixed-register addressing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattia-moffa
changed the title
Member
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates armasm after the fix in wolfssl/scripts#625
Fixes zd#22040
Testing
armasm-test.tar.gz