Skip to content

2020714 Coverity fixes #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlm2002 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

2020714 Coverity fixes #10902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b89b25
clear dereference before null check in myCryptoDevCb()
rlm2002 Jul 10, 2026
e406bab
Direct compare paramTo->check_time == 11 to prevent store_truncates_t…
rlm2002 Jul 13, 2026
e9d6701
Remove dead check
rlm2002 Jul 14, 2026
8f750dd
limit extLen to MAX_RECORD_SIZE
rlm2002 Jul 14, 2026
8cfe165
initialize uninitialized variables in tests
rlm2002 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27241,11 +27241,6 @@ int SendCertificateStatus(WOLFSSL* ssl)
else {
while (ret == 0 && i < MAX_CHAIN_DEPTH &&
NULL != (request = ssl->ctx->chainOcspRequest[i])) {
if ((i + 1) >= MAX_CERT_EXTENSIONS) {
ret = MAX_CERT_EXTENSIONS_ERR;
break;
}

request->ssl = ssl;
ret = CheckOcspRequest(SSL_CM(ssl)->ocsp_stapling,
request, &responses[++i], ssl->heap);
Expand Down
3 changes: 3 additions & 0 deletions tests/api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15015,6 +15015,9 @@ static int ech_find_extension(byte* buf, word16* idx_p, word16 extType)
if (seekRet < 0) {
return seekRet;
}
if (extLen > MAX_RECORD_SIZE) {
return BAD_FUNC_ARG;
}
idx = extIdx = ((word16)seekRet + *idx_p);

while (idx - extIdx < extLen) {
Expand Down
13 changes: 13 additions & 0 deletions tests/api/test_dh.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,9 @@ int test_wc_DhAgree_nonblock(void)
int ret;
int rounds;

XMEMSET(&aliceKey, 0, sizeof(aliceKey));
XMEMSET(&bobKey, 0, sizeof(bobKey));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectIntEQ(wc_InitDhKey(&aliceKey), 0);
ExpectIntEQ(wc_InitDhKey(&bobKey), 0);
Expand Down Expand Up @@ -691,6 +694,8 @@ int test_wc_DhImportExportKeyPair(void)
byte privOut[TEST_DH_BUF_SIZE], pubOut[TEST_DH_BUF_SIZE];
word32 privOutSz, pubOutSz;

XMEMSET(&key, 0, sizeof(key));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectIntEQ(wc_InitDhKey(&key), 0);
ExpectIntEQ(wc_DhSetNamedKey(&key, WC_FFDHE_2048), 0);
Expand Down Expand Up @@ -770,6 +775,8 @@ int test_wc_DhCheckPubKey(void)
word32 privSz = sizeof(priv), pubSz = sizeof(pub);
byte tiny[1] = { 0x01 };

XMEMSET(&key, 0, sizeof(key));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectNotNull(params = wc_Dh_ffdhe2048_Get());

Expand Down Expand Up @@ -838,6 +845,8 @@ int test_wc_DhCheckPrivKey(void)
word32 privSz = sizeof(priv), pubSz = sizeof(pub);
byte zero[1] = { 0x00 };

XMEMSET(&key, 0, sizeof(key));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectNotNull(params = wc_Dh_ffdhe2048_Get());
ExpectIntEQ(wc_InitDhKey(&key), 0);
Expand Down Expand Up @@ -910,6 +919,8 @@ int test_wc_DhCheckKeyPair(void)
byte priv[TEST_DH_BUF_SIZE] = {0}, pub[TEST_DH_BUF_SIZE] = {0};
word32 privSz = sizeof(priv), pubSz = sizeof(pub);

XMEMSET(&key, 0, sizeof(key));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectIntEQ(wc_InitDhKey(&key), 0);
ExpectIntEQ(wc_DhSetNamedKey(&key, WC_FFDHE_2048), 0);
Expand Down Expand Up @@ -970,6 +981,8 @@ int test_wc_DhGenerateParams_and_ExportRaw(void)
byte gOut[TEST_DH_BUF_SIZE];
word32 pSz, qSz, gSz;

XMEMSET(&dh, 0, sizeof(dh));

ExpectIntEQ(wc_InitRng(&rng), 0);
ExpectIntEQ(wc_InitDhKey(&dh), 0);

Expand Down
1 change: 1 addition & 0 deletions tests/api/test_ed25519.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,7 @@ int test_wc_ed25519_verify_streaming(void)

XMEMSET(&key, 0, sizeof(key));
XMEMSET(&rng, 0, sizeof(WC_RNG));
XMEMSET(sig, 0, sizeof(sig));

ExpectIntEQ(wc_ed25519_init(&key), 0);
ExpectIntEQ(wc_InitRng(&rng), 0);
Expand Down
4 changes: 2 additions & 2 deletions tests/api/test_ossl_x509_vp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@ int test_wolfSSL_X509_VERIFY_PARAM(void)
paramTo->flags = WOLFSSL_USE_CHECK_TIME;
paramFrom->check_time = 22;
ExpectIntEQ(X509_VERIFY_PARAM_inherit(paramTo, paramFrom), 1);
ExpectIntEQ(paramTo->check_time, 11);
ExpectIntEQ(paramTo->check_time == 11, 1);
ExpectIntEQ(paramTo->flags & WOLFSSL_USE_CHECK_TIME,
WOLFSSL_USE_CHECK_TIME);

paramTo->inherit_flags = X509_VP_FLAG_OVERWRITE;
ExpectIntEQ(X509_VERIFY_PARAM_inherit(paramTo, paramFrom), 1);
ExpectIntEQ(paramTo->check_time, 22);
ExpectIntEQ(paramTo->check_time == 22, 1);
ExpectIntEQ(paramTo->flags & WOLFSSL_USE_CHECK_TIME, 0);

/* test for incorrect parameters */
Expand Down
4 changes: 2 additions & 2 deletions wolfcrypt/test/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75717,7 +75717,7 @@ static int myCryptoDevCb(int devIdArg, wc_CryptoInfo* info, void* ctx)
use SW */
myCryptoDevCtx* myCtx = (myCryptoDevCtx*)ctx;

if (info == NULL)
if (info == NULL || myCtx == NULL)
return BAD_FUNC_ARG;

#ifdef DEBUG_WOLFSSL
Expand Down Expand Up @@ -76010,7 +76010,7 @@ static int myCryptoDevCb(int devIdArg, wc_CryptoInfo* info, void* ctx)
}
else {
ret = 0;
if (myCtx != NULL && myCtx->eccCheckPubExpectZeroPoint) {
if (myCtx->eccCheckPubExpectZeroPoint) {
const byte* pub = info->pk.ecc_check_pub.pubKey;
word32 curveSz = (word32)k->dp->size;
word32 ptSz = 1 + 2 * curveSz;
Expand Down
Loading