Return new error CTX_BUSY_E on APIs which would modify aliased buffers#10877
Closed
padelsbach wants to merge 1 commit into
Closed
Return new error CTX_BUSY_E on APIs which would modify aliased buffers#10877padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
force-pushed
the
block-apis-in-sni-callback
branch
3 times, most recently
from
July 12, 2026 15:23
d4cab69 to
1ad1b86
Compare
Contributor
Author
|
jenkins retest this please |
padelsbach
marked this pull request as ready for review
July 13, 2026 01:07
|
retest this please |
|
padelsbach
force-pushed
the
block-apis-in-sni-callback
branch
2 times, most recently
from
July 13, 2026 15:43
0726d1e to
8334a19
Compare
padelsbach
force-pushed
the
block-apis-in-sni-callback
branch
from
July 13, 2026 16:27
8334a19 to
fbd0cf2
Compare
padelsbach
marked this pull request as draft
July 13, 2026 22:59
Contributor
Author
|
Rolling this into the hybrid approach in #10905. Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternate approach to #10860. Prevent several APIs from running in SNI callback since they would free buffers pointed to by both the
WOLFSSLandWOLFSSL_CTXobjects.Fixes zd 22107
The full list of newly disallowed functions is below. Instead, applications should use
wolfSSL_use_certificate_file,wolfSSL_use_PrivateKey_file,wolfSSL_SetTmpDH,wolfSSL_set_SSL_CTX,wolfSSL_CTX_load_verify_locations.Certificate (leaf)
Certificate chain
Private key
Alt private key (WOLFSSL_DUAL_ALG_CERTS)
DH parameters
Cert manager
Testing
Added unit tests.
Checklist