ML-DSA renaming part 2#10497
Conversation
|
Frauschi
force-pushed
the
mldsa_rename
branch
3 times, most recently
from
5925eff to
306b9cb
Compare
|
Jenkins retest this please |
There was a problem hiding this comment.
Pull request overview
This PR continues the internal Dilithium → ML-DSA (FIPS 204) naming migration by consolidating ML-DSA size/parameter macros under canonical spellings and extending the legacy <wolfssl/wolfcrypt/dilithium.h> shim to keep older macro names and tuning knobs working.
Changes:
- Replaced redundant
DILITHIUM_*/ML_DSA_LEVEL*size macro families inwc_mldsa.hwith canonicalWC_MLDSA_{44,65,87}_*_SIZEandMLDSA_*algorithm-parameter macros. - Added legacy macro/tuning-knob forward-translation and extensive macro aliasing to
wolfssl/wolfcrypt/dilithium.h. - Updated migration documentation and the known-macro extras list.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wolfssl/wolfcrypt/wc_mldsa.h |
Consolidates ML-DSA parameter-set sizing macros and renames internal parameter macros from DILITHIUM_* to MLDSA_*. |
wolfssl/wolfcrypt/dilithium.h |
Extends the compatibility shim to forward-translate legacy tuning knobs and provide reverse macro aliases for legacy names. |
doc/dilithium-to-mldsa-migration.md |
Documents the macro family consolidation and naming rules for retained identifiers/gates. |
.wolfssl_known_macro_extras |
Updates the macro whitelist (adds MLDSA_USE_HINT_CT, removes two CryptoCb-only macros). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frauschi
force-pushed
the
mldsa_rename
branch
2 times, most recently
from
eab7426 to
eae29d5
Compare
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
unrecognized macros used:
WOLFSSL_NO_ML_DSA_LEGACY_NAMES
add well-formed but unknown macros to .wolfssl_known_macro_extras at top of source tree.
Fixed with the latest force-push. |
More internal ML-DSA renaming