fix for CAAM build#10459
Open
JacobBarthelmeh wants to merge 2 commits into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10459
Scan targets checked: wolfcrypt-port-bugs
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes build issues in the CAAM hash port by correcting incorrect structure member references and pointer types used when building CAAM buffer descriptors for SHA-224 operations and the shared update routine.
Changes:
- Fix
_ShaUpdate()to use itsctxandbufferparameters instead of referencing a non-existentshavariable (sha->ctx,sha->buffer). - Fix SHA-224 CAAM wrapper to use the correct
wc_Sha224field name (buffLen), and add the required cast when passingsha224->bufferinto_ShaUpdate().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
Retest this please Jenkins. Clicking on the fail link shows no history. |
Contributor
Author
|
Retest this please Jenkins. FIPS harness test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F - 593