Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #621
Scan targets checked: wolfssl-examples-src, wolfssl-examples-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
| #include <netinet/in.h> | ||
| #include <unistd.h> | ||
|
|
||
| #ifdef HAVE_SIGNAL |
There was a problem hiding this comment.
SIGINT cleanup handler is never compiled in (HAVE_SIGNAL never defined) · Dead/unreachable code
Unlike every sibling server example, this file omits #define HAVE_SIGNAL before the guard, so signal.h, sig_handler (lines 94-109), and the signal(SIGINT, sig_handler) call at line 129 are all excluded from every build and Ctrl-C never runs the socket cleanup path. If HAVE_SIGNAL is supplied by wolfssl/options.h (included at line 50, after the guard), signal.h is still not pulled in and line 129 fails to compile.
Suggested fix: Add #define HAVE_SIGNAL immediately before the #ifdef HAVE_SIGNAL include guard, matching tls/server-tls13.c.
3 participants
Fixes ZD 22369