sftp: NULL fName after free in all readdir variants#978
Merged
Conversation
- Apply the prior FATFS fix across Nucleus, MQX, Windows, Zephyr, Harmony, and user-filesystem readdir paths. - Prevents double-free crash when SFTPNAME_free runs on a name struct after readdir returns an error.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the SFTP readdir error-cleanup fix by clearing out->fName after freeing it in several filesystem-specific implementations, preventing later cleanup from double-freeing the same pointer.
Changes:
- Adds
out->fName = NULLafter error-path frees in user-filesystem, Nucleus, MQX, Windows, Zephyr, Harmony, and default POSIX-stylereaddirpaths. - Keeps the existing SFTP name allocation and long-name creation flow unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #978
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
padelsbach
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #973.