Skip to content

Add check for all zeros in CreateMpint #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejohnstown merged 1 commit into from
Apr 21, 2026
Merged

Add check for all zeros in CreateMpint #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4636,6 +4636,13 @@ static int CreateMpint(byte* buf, word32* sz, byte* pad)
if (buf[i] != 0x00)
break;
}
/* all-zero buffer encodes as empty mpint per RFC 4251 */
if (i == *sz) {
*pad = 0;
*sz = 0;
return WS_SUCCESS;
}

*pad = (buf[i] & 0x80) ? 1 : 0;

/* if padding would be needed and have leading 0's already then do not add
Expand Down
Loading