Add DH Group 16 and HMAC-SHA2-512 #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note, this is expected to conflict with #763 around the test area, I can fix that when it happens. |
LinuxJedi
force-pushed
the
more-kex
branch
5 times, most recently
from
d7c80da to
3e95486
Compare
Member
Author
|
Tweaked the Zephyr packet size as the slightly larger KEX packet blows the tiny default TX buffer. |
Member
Author
|
Moved to draft, there is a bug in HMAC-SHA2-512 which I am investigating. |
Member
Author
|
Problem found, should be good now. |
ejohnstown
previously approved these changes
Feb 10, 2025
This adds the `diffie-hellman-group16-sha512` key exchange and `hmac-sha2-512` mac support. Echoserver can now take `-x` for key exchange and `-m` for mac setting, and `-c` for cipher so that this can be used in the test suite.
Member
Author
|
Rebased to fix merge conflicts. |
JacobBarthelmeh
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
diffie-hellman-group16-sha512key exchange andhmac-sha2-512mac support.Echoserver can now take
-xfor key exchange and-mfor mac setting, so that this can be used in the test suite.New test added for this and it has been tested against OpenSSH.