coverage: survive a truncated raw profile - #1249
Merged
Merged
Conversation
The merge step takes --failure-mode=all, so a raw profile left short by a killed process is warned about and skipped instead of aborting the report. Tests SIGKILL their servers in cleanup traps, and a process killed while writing its profile leaves a corrupt header behind. The step still fails when no profile can be read at all.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues remain, and failure is preserved when no usable profiles are available.
Pull request overview
This pull request makes coverage profile merging resilient to isolated truncated raw profiles while preserving failure when no valid profiles exist.
Changes:
- Uses
llvm-profdata-18 merge --failure-mode=all. - Documents truncated profile handling.
File summaries
| File | Summary |
|---|---|
.github/workflows/code-coverage.yml |
Adjusts raw profile merging to tolerate isolated corrupt files. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
padelsbach
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Code Coverage job has been failing intermittently on master and on PR branches. Every test passes; the merge of the raw profiles is what exits 1.