20260713-wc_AesGcmEncrypt_fips#30
Open
douzzer wants to merge 1 commit into
Open
Conversation
* Implement !WC_FIPS_AESGCM_ONE_SHOT_EXT_IV_ALLOWED code paths in wc_AesGcm_Appended_Tag_Encrypt() and non-streaming version of wc_AesGcm_crypt_sg_inplace(), using strictly FIPS-allowed APIs. * For streaming wc_AesGcm_crypt_sg_inplace(), disable FIPS status checks in wc_AesGcmDecryptUpdate() and wc_AesGcmEncryptUpdate() to avoid frivolous sync memory operations. Rely on the final status check by wc_AesGcmDecryptFinal() / wc_AesGcmEncryptFinal(). kernel-src/noise.c, kernel-src/receive.c, kernel-src/selftest/allowedips.c, kernel-src/send.c, kernel-src/wolfcrypt_glue.h: Whitespace, comment, and WC_DEBUG_*() bikeshedding, and add WC_DEBUG_PR_CODEPOINT_VAL().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernel-src/wolfcrypt_glue.[ch]:WC_FIPS_AESGCM_ONE_SHOT_EXT_IV_ALLOWEDcode paths inwc_AesGcm_Appended_Tag_Encrypt()and non-streaming version ofwc_AesGcm_crypt_sg_inplace(), using strictly FIPS-allowed APIs.wc_AesGcm_crypt_sg_inplace(), disable FIPS status checks inwc_AesGcmDecryptUpdate()andwc_AesGcmEncryptUpdate()to avoid frivolous sync memory operations. Rely on the final status check bywc_AesGcmDecryptFinal()/wc_AesGcmEncryptFinal().kernel-src/noise.c,kernel-src/receive.c,kernel-src/selftest/allowedips.c,kernel-src/send.c,kernel-src/wolfcrypt_glue.h: Whitespace, comment, andWC_DEBUG_*() bikeshedding, and addWC_DEBUG_PR_CODEPOINT_VAL().tested in conjunction with wolfSSL/wolfssl#10920 and wolfssl/fips#402