Conversation
Guard wolfCLU_Base64Help() and base64_options behind WOLFCLU_BASE64_ENABLED to prevent -Wunused-function / -Wunused-const-variable errors on a --disable-filesystem build. Add similar guards to s_server example paths. Update Python tests to skip file-backed subcommands when filesystem support is disabled.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #297
Scan targets checked: wolfclu-src, wolfclu-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard wolfCLU_Base64Help() and base64_options behind WOLFCLU_BASE64_ENABLED to prevent -Wunused-function / -Wunused-const-variable errors on a --disable-filesystem build. Add similar guards to s_server example paths.
Update Python tests to skip file-backed subcommands when filesystem support is disabled.