Skip to content

Fixed "No such file or directory" error when $dirname contains spaces#11

Open
junjie wants to merge 1 commit into
wojteklu:masterfrom
junjie:master
Open

Fixed "No such file or directory" error when $dirname contains spaces#11
junjie wants to merge 1 commit into
wojteklu:masterfrom
junjie:master

Conversation

@junjie

@junjie junjie commented Jun 12, 2020

Copy link
Copy Markdown

This fixes #10 Script fails if $dirname contains spaces

@garvankeeley

garvankeeley commented Nov 19, 2020

Copy link
Copy Markdown

Pinging @wojteklu to land, thanks!

garvankeeley added a commit to garvankeeley/xcode-open-on-github that referenced this pull request Nov 19, 2020
@hlung

hlung commented Mar 23, 2021

Copy link
Copy Markdown

@wojteklu merge it dude!

@mkaulfers

Copy link
Copy Markdown

I'd like to see this merged in too.

@mr-fixit

Copy link
Copy Markdown

ever hopeful, i upvote the idea of merging this...

@garvankeeley

Copy link
Copy Markdown

My forked version is what I have used for years, it uses gh CLI tool and is very reliable for any type of repo structure (because gh does all the work): https://github.com/garvankeeley/xcode-open-on-github

@mr-fixit

Copy link
Copy Markdown

fwiw, here's a script that'll generate the github URL of the frontmost file in Xcode, even if the file is SPM source in the DerivedData tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script fails if $dirname contains spaces

5 participants