Open
Conversation
Model used in the test is a model that does not implement IVision but can read via OCR. LLM service silently packed the images from OCR source to the IVision source and prevented OCR to work as intended.
- Previous integration tests are moved to E2E test project as they need real api keys or local inference and their duration is long. - New integration test project holds tests that have mocked HTTP Handlers so we can test integration between modules without time-consuming external dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are long and discourage devs to run them as they take 15 min. Many of the tests does not even need runnig the model to test what they want to test so (so many "test"...).
Rename integration tests to E2E tests. Those tests are long and need api keys or local inference
Add new integration tests project designed for relatively quick tests testing integration between parts of the library with mocked HTTP calls or local model inference so they are deterministic and quick.
Use smaller and faster model for E2E tests so it has to be downloaded for the succesful test execution.
Add some integration tests.
Fix the vision logic (details in the cdbe368 commit)
Currently integration tests cannot run in parallel as the service configuration is global. Take care of it in the next PR.