fix: new conversation close crash [WPB-26127] [WPB-26131]#4933
Open
MohamadJaara wants to merge 1 commit into
Open
fix: new conversation close crash [WPB-26127] [WPB-26131]#4933MohamadJaara wants to merge 1 commit into
MohamadJaara wants to merge 1 commit into
Conversation
|
MohamadJaara
changed the title
MohamadJaara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26127
Summary
Fixes a crash when closing the New Conversation screen.
What was happening
When tapping the X button, the app navigates back to the conversation list.
During the screen exit animation, the New Conversation screen can still be composed for a short moment. At that point, the New Conversation graph was already removed from the navigation back stack, but the screen tried to look it up again.
That caused this crash:
Fix
Keep the New Conversation parent back stack entry remembered for the lifetime of the screen composition, instead of looking it up again after navigation starts.
Testing
Manually