fix: metro graph handoff after logout [WPB-26140] [WPB-26141]#4932
Open
MohamadJaara wants to merge 4 commits into
Open
fix: metro graph handoff after logout [WPB-26140] [WPB-26141]#4932MohamadJaara wants to merge 4 commits into
MohamadJaara wants to merge 4 commits into
Conversation
MohamadJaara
force-pushed
the
mo/refactor/nuke-hilt
branch
from
6b85347 to
5b718bf
Compare
MohamadJaara
changed the title
MohamadJaara
requested review from
alexandreferris,
ohassine,
sbakhtiarov,
typfel and
yamilmedina
and removed request for
a team
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
# Conflicts: # app/src/androidTest/kotlin/com/wire/android/TestCoreLogicModule.kt # app/src/main/kotlin/com/wire/android/ui/WireActivity.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt # kalium
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26140
Summary
Fixes the logout/login handoff after the Hilt to Metro migration.
What was happening
On logout, the app clears the current user while Compose may still be drawing the old logged-in screen. That old screen still needs the session ViewModel graph for a short moment.
Keeping that graph around fixed the logout crash, but the login screen could briefly reuse the old user-scoped ViewModel key.
Also logging in with a second account was not working
Fix
Testing
Manual verification