Skip to content

fix: duplicate offline indicator in conversation (WPB-25293)#4928

Open
sbakhtiarov wants to merge 1 commit into
developfrom
fix/offline-indicator-issue
Open

fix: duplicate offline indicator in conversation (WPB-25293)#4928
sbakhtiarov wants to merge 1 commit into
developfrom
fix/offline-indicator-issue

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented Jun 4, 2026

https://wearezeta.atlassian.net/browse/WPB-25293

https://wearezeta.atlassian.net/browse/WPB-25293

What's new in this PR?

Fixing issue with duplicate offline indicator appearing in messages list.

@MohamadJaara
Copy link
Copy Markdown
Member

@sergeibakhtiarov does it need to go into main ?

@sbakhtiarov sbakhtiarov force-pushed the fix/offline-indicator-issue branch from f9cb9e2 to c50334b Compare June 4, 2026 13:25
@sbakhtiarov sbakhtiarov force-pushed the fix/offline-indicator-issue branch from c50334b to 8bd9f03 Compare June 4, 2026 14:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

@sbakhtiarov
Copy link
Copy Markdown
Contributor Author

@sergeibakhtiarov does it need to go into main ?

Yes, need to merge it, there is a risk of crash in case of duplicate message.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.35%. Comparing base (ed4336d) to head (8bd9f03).

Files with missing lines Patch % Lines
...ersations/messages/item/OfflineMessageIndicator.kt 75.00% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4928   +/-   ##
========================================
  Coverage    49.34%   49.35%           
========================================
  Files          646      646           
  Lines        22851    22853    +2     
  Branches      3502     3503    +1     
========================================
+ Hits         11276    11278    +2     
  Misses       10529    10529           
  Partials      1046     1046           
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewModel.kt 69.74% <ø> (ø)
...ersations/messages/item/OfflineMessageIndicator.kt 92.59% <75.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4336d...8bd9f03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants