fix: home drawer keyboard focus trap [WPB-14804]#4907
Open
Garzas wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4907 +/- ##
===========================================
- Coverage 50.40% 50.24% -0.17%
===========================================
Files 626 628 +2
Lines 22192 22263 +71
Branches 3427 3440 +13
===========================================
Hits 11186 11186
- Misses 9969 10040 +71
Partials 1037 1037
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-14804
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Fixed issues:
Causes
The home drawer stayed composed while closed and relied mostly on default Compose focus traversal. This allowed hidden drawer content and background screen content to remain reachable depending on focus state.
The drawer item list also had no explicit forward/backward focus loop, and the spacer between top and bottom drawer items could become a focus target.
Solutions
TABfrom the last item returns to the first item, andSHIFT+TABworks in reverse.ESC/Back handling to close the drawer from keyboard navigation.HomeScreen.ktintoHomeScaffold.ktto keep the screen file smaller and easier to review.