Skip to content

fix: show invalid credentials error on login screens [WPB-14814]#4903

Open
Garzas wants to merge 4 commits into
developfrom
fix/login-invalid-credentials-error-marking
Open

fix: show invalid credentials error on login screens [WPB-14814]#4903
Garzas wants to merge 4 commits into
developfrom
fix/login-invalid-credentials-error-marking

Conversation

@Garzas
Copy link
Copy Markdown
Contributor

@Garzas Garzas commented Jun 1, 2026

https://wearezeta.atlassian.net/browse/WPB-14814


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Shows a persistent invalid credentials error on the login screen after the dialog is dismissed
  • Applies the same error marking to both old and new email/password login flows
  • Keeps the message generic to avoid revealing whether the email/username or password was incorrect
  • Clears the inline error once the user edits the login input
  • Adds ViewModel coverage for preserving and clearing the error state

@Garzas Garzas requested review from MohamadJaara and saleniuk June 1, 2026 11:06
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.41%. Comparing base (4227187) to head (f9fc72f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4903      +/-   ##
===========================================
+ Coverage    50.40%   50.41%   +0.01%     
===========================================
  Files          626      626              
  Lines        22192    22198       +6     
  Branches      3427     3429       +2     
===========================================
+ Hits         11186    11192       +6     
  Misses        9969     9969              
  Partials      1037     1037              
Files with missing lines Coverage Δ
...d/ui/authentication/login/email/LoginEmailState.kt 100.00% <100.00%> (ø)
.../authentication/login/email/LoginEmailViewModel.kt 79.25% <100.00%> (+0.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227187...f9fc72f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas requested a review from saleniuk June 2, 2026 03:41
@Garzas Garzas requested a review from saleniuk June 2, 2026 18:49
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants