Preserve command cancellation and clean up failed runtime startup - #704
Merged
Merged
Conversation
skhaz
approved these changes
Sep 9, 2026
wolfy-j
marked this pull request as draft
September 9, 2026 21:19
wolfy-j
marked this pull request as ready for review
September 9, 2026 21:45
skhaz
approved these changes
Sep 10, 2026
wolfy-j
force-pushed
the
fix/runtime-command-cleanup
branch
from
September 10, 2026 18:45
4dbd7c7 to
884a9b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartThe change reuses the existing loader and shutdown pipeline. It adds one parent-aware bootstrap entry point and one command-local one-shot cleanup owner; no runtime protocol or configuration surface is introduced.
Regression coverage
Tests cover parent cancellation/value/deadline propagation, partial-load cleanup, pre-start dispatcher cleanup, pack-start failure, normal shutdown, cancellation without a signal, and prevention of duplicate shutdown.
Verification
go vetgo mod verifygit diff --check