prevent users from editing "formatting characters"#287
Open
sumanthratna wants to merge 2 commits intowinmarkltd:masterfrom
sumanthratna:patch-1
Open
prevent users from editing "formatting characters"#287sumanthratna wants to merge 2 commits intowinmarkltd:masterfrom sumanthratna:patch-1
sumanthratna wants to merge 2 commits intowinmarkltd:masterfrom
sumanthratna:patch-1
Conversation
for example, disallows deleting the "1+ " in the "+1 (ddd) ddd-dddd" format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this edit, viewers of the page could backspace the "1+" and type more than the allowed characters (according to the format specified) and then the JS would retype/delete the text to make it comply with the format. This edit prevents the user from editing the format in the first place, allowing for a cleaner UI.