Added increament/decreament steps.#207
Open
gongdo wants to merge 1 commit intowinmarkltd:masterfrom
gongdo:master
Open
Added increament/decreament steps.#207gongdo wants to merge 1 commit intowinmarkltd:masterfrom gongdo:master
gongdo wants to merge 1 commit intowinmarkltd:masterfrom
gongdo:master
Conversation
When bfhnumbers need to increase or decrease the value, it uses options.steps instead of 1. Default value of options.steps is 1, obviously. Modified getValue function, to use jQuery.isNumeric() which is perfect to check numeric value. Also added some unit tests for this as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bfhnumber need to increase or decrease the value, it uses
options.steps instead of 1.
Default value of options.steps is 1, obviously.
Modified getValue function, to use jQuery.isNumeric() which is perfect
to check numeric value.
Also added some unit tests for this as well.