Skip to content

Upgrade Node.js to v22 in CI workflows #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willtheorangeguy merged 1 commit into from
Mar 24, 2026
Merged

Upgrade Node.js to v22 in CI workflows #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/astro.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v6
with:
node-version: "20"
node-version: "22"
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astro v6 requires Node.js >= 22.12.0 (per PR description). node-version: "22" only pins the major and can resolve to an earlier 22.x release depending on what setup-node selects, which could reintroduce the build failure. Consider pinning to at least 22.12.0 (or 22.12.x) to enforce the minimum supported version deterministically.

Suggested change
node-version: "22"
node-version: "22.12.0"

Copilot uses AI. Check for mistakes.
cache: ${{ steps.detect-package-manager.outputs.manager }}
cache-dependency-path: ${{ env.BUILD_PATH }}/${{ steps.detect-package-manager.outputs.lockfile }}
- name: Create .env file
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-google-maps-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: '20'
node-version: '22'
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astro v6 requires Node.js >= 22.12.0 (per PR description). node-version: '22' only pins the major and may resolve to an earlier 22.x release, which could break scripts if they assume the minimum supported version. Consider pinning to 22.12.0 (or 22.12.x) here as well for deterministic workflow behavior.

Suggested change
node-version: '22'
node-version: '22.12.0'

Copilot uses AI. Check for mistakes.
cache: 'pnpm'

- name: Install dependencies
Expand Down
Loading