feat: pass dragged images to backend as session/send attachments#26
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
william0wang
added a commit
that referenced
this pull request
Jul 23, 2026
…backend (#27) * feat: support custom model providers in the model dropdown * fix: surface real backend error instead of misleading version string in session/subscribe * fix: stop sending runtimeModel overlay in session/resume to fix Invalid params * fix: never send provider.apiKey in runtimeModel overlay and drop builtin model prefix * fix: switch models via session/setModel to work with new backend protocol * fix: refresh context bar with new model's window after model switch * refactor: simplify runtime model test data with generic provider names * fix: retry transient session/subscribe timeouts to absorb preempt busy window * Squashed commit of the following: commit 30e9abe Author: William Wang <william@10ln.com> Date: Thu Jul 23 19:58:51 2026 +0800 feat: pass dragged images to backend as session/send attachments (#26) * fix: stop duplicating text under elicitation form * fix: probe lock state in preempt instead of polling pendingTurns * fix: drop includeSnapshot from subscribe to eliminate snapshot-induced timeouts session/subscribe carried includeSnapshot:true but the returned snapshot was immediately discarded (void snapshot) — the projection baseline comes from a separate fetchMessages call. Asking the backend for a snapshot forced it to compute a full O(messages) session snapshot on every prompt, which the backend logs show taking 3.8s at 267 messages and up to 38s at 3500 messages, blowing past the 10s per-attempt subscribe timeout. Switch to includeSnapshot:false; only the eventSeq watermark is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.