Replace jsReady.js and moduleReady.js with waitForNetworkIdle call#129
Draft
nicholasray wants to merge 1 commit intomainfrom
Draft
Replace jsReady.js and moduleReady.js with waitForNetworkIdle call#129nicholasray wants to merge 1 commit intomainfrom
nicholasray wants to merge 1 commit intomainfrom
Conversation
nicholasray
changed the title
nicholasray
force-pushed
the
remove-js-ready
branch
from
4a2ac36 to
7e960da
Compare
nicholasray
force-pushed
the
remove-js-ready
branch
3 times, most recently
from
88924cd to
b571827
Compare
nicholasray
changed the title
nicholasray
force-pushed
the
remove-js-ready
branch
3 times, most recently
from
3bd1ac0 to
2252a30
Compare
jsReady.js and moduleReady.js effectively wait for various JS resource loader modules to load which can be tedious to write and error prone. There might be a better and more future-proof alternative by waiting for the network to idle instead. Therefore, this commit: * Replaces all usages of waitForModule with waitForNetworkIdle * Removes moduleReady.js and jsReady.js Bug: T322454
nicholasray
force-pushed
the
remove-js-ready
branch
from
2252a30 to
8c788d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsReady.js and moduleReady.js effectively wait for various JS resource loader modules to load which can be tedious to write and error prone. There might be a better and more future-proof alternative by waiting for the network to idle instead.
Therefore, this commit: