Skip to content

[WV-2599] Fix fragile styled-components selector in FAQ page title Element#4833

Open
tarunramireddy wants to merge 5 commits into
wevote:developfrom
tarunramireddy:fix/faq-regression-fixes
Open

[WV-2599] Fix fragile styled-components selector in FAQ page title Element#4833
tarunramireddy wants to merge 5 commits into
wevote:developfrom
tarunramireddy:fix/faq-regression-fixes

Conversation

@tarunramireddy

@tarunramireddy tarunramireddy commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What github.com/wevote/WebApp/issues does this fix?

WV-2599 — Regression run failure analysis and fixes for FAQ, Terms page, and VerifyCount

Changes included this pull request?

  • FAQ: Replace fragile styled-components auto-generated class selector (.kkIyuQ) with stable text selector (h1=Frequently Asked Questions) in faq.browser.js
  • Terms: Add missing getTermsLinkElement getter (#footerLinkTermsOfUse) in ready.browser.js; add pageContentTitleText getter in privacy.browser.js; fix it.only → it in TermsPage.browser.js so all 3 tests run
  • VerifyCount: Remove incorrect driver.switchWindow() calls — value pages use SPA in-page navigation (same tab, no new window); remove duplicate class body in ready.browser.js that had a broken login() using #emailVerifyButton instead of #phoneVerifyButton; add window.scrollTo(0,0) and waitForClickable(30s) before sign-out avatar click in endorsers tests

@tarunramireddy
[WV-2599] Fix fragile styled-components selector in FAQ page title el…
94b1b0b 
…ement

Replace auto-generated CSS class .kkIyuQ with stable text-based selector
so the test does not break when styled-components regenerates class names
on each build.
Copilot AI review requested due to automatic review settings June 6, 2026 17:23
@tarunramireddy tarunramireddy marked this pull request as draft June 6, 2026 17:23
Copilot AI reviewed Jun 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the FAQ page object to locate the page title using a more semantic selector rather than a generated CSS class.

Changes:

  • Replaces a CSS class selector for the FAQ page title with an element/text-based selector.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/browserstack_automation/page_objects/faq.browser.js
@tarunramireddy
[WV-2599] Fix Terms page regression failures
90b7c61 
- Remove it.only from verifyGitHubLinkRedirected so all three tests run
- Add missing getTermsLinkElement getter to ReadyPage using #footerLinkTermsOfUse
- Add missing pageContentTitleText getter to PrivacyPage using stable h1 text selector
@tarunramireddy
[WV-2599] Fix VerifyCount regression failures
88caa55 
- Remove driver.switchWindow() calls for in-page SPA navigation (value pages open in same tab, not new window)
- Add window.scrollTo(0,0) before avatar sign-out click in endorsers tests (page is deeply scrolled after scrollIntoView on showMoreItemsId)
- Use waitForClickable with 30s timeout for avatar after endorsers section (OrganizationList re-render after loading all endorsers takes longer than default 10s)
- Remove duplicate class body from ready.browser.js that contained a broken login() using #emailVerifyButton instead of #phoneVerifyButton
@tarunramireddy
Merge branch 'develop' of https://github.com/wevote/WebApp into fix/f…
2cdfe93 
…aq-regression-fixes
@tarunramireddy
Element Change on X (twitter)
bcfc61a
@charanya-QA

charanya-QA commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@tarunramireddy Thanks for the changes . I see that PR is in draft status . Are you planning to change it to open?

@tarunramireddy tarunramireddy marked this pull request as ready for review June 17, 2026 20:22
charanya-QA
charanya-QA reviewed Jun 17, 2026
View reviewed changes

@charanya-QA charanya-QA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunramireddy : Thanks for helping ! Could you pls check the ready page object file alone ? Rest all looks good!

Comment thread tests/browserstack_automation/page_objects/ready.browser.js

@charanya-QA charanya-QA Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunramireddy : I see few functions are deleted here but they are being used in the spec file. Could you pls help to understand? line 604 to 761

@tarunramireddy tarunramireddy Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charanya-QA It’s not ready yet. I’ll confirm once this pull request is ready

Comment thread tests/browserstack_automation/page_objects/privacy.browser.js

@charanya-QA charanya-QA Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunramireddy : Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@charanya-QA charanya-QA charanya-QA left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarunramireddy @charanya-QA