test(session): add TODO for fee-payer sponsored settle/close tests#248
Closed
brendanjryan wants to merge 1 commit intofix/settle-sender-separationfrom
Closed
test(session): add TODO for fee-payer sponsored settle/close tests#248brendanjryan wants to merge 1 commit intofix/settle-sender-separationfrom
brendanjryan wants to merge 1 commit intofix/settle-sender-separationfrom
Conversation
The escrow contract requires msg.sender == payee for settle() and close(). The sendFeePayerTx helper used the fee payer as both sender and gas sponsor, causing every fee-sponsored settlement/close to revert with NotPayee(). Fix sendFeePayerTx to accept a separate account (logical sender) and feePayer (gas sponsor). Update settleOnChain and closeOnChain to resolve and pass the correct account. Add account option to the top-level tempo.settle() API. Also fix feeToken resolution to use resolveCurrency() which falls back to pathUsd for unknown chain IDs (e.g. localnet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #247. Adds TODO comments for on-chain fee-payer tests with distinct sender ≠ feePayer.
During development we discovered that localnet's
msg.senderresolves to the fee payer address in sponsored 0x76 txs, so the escrow contract'ssettle()/close()revert withNotPayee()when sender ≠ feePayer. These tests need a testnet or mainnet environment.The existing tests still cover:
settles a channel— unsponsored settle viawriteContractsettles with explicit account (no fee payer)— validates the newaccountparam is used as senderthrows when no account available— fail-fast when neitheraccountnorclient.accountis setStacked on #247.