Skip to content

fix: bind tempo attribution memo suffix to challenge id#232

Closed
brendanjryan wants to merge 3 commits intomainfrom
brendanjryan/charge-7byte-attribution
Closed

fix: bind tempo attribution memo suffix to challenge id#232
brendanjryan wants to merge 3 commits intomainfrom
brendanjryan/charge-7byte-attribution

Conversation

@brendanjryan
Copy link
Copy Markdown
Collaborator

Summary

  • bind SDK-generated Tempo attribution memos to the current challenge by reusing the trailing 7 bytes
  • add same-challenge replay protection in Mppx via NonceSet and a reserved internal challenge nonce
  • keep explicit custom memos and plain/no-memo transfers on the existing store-backed fallback path

Testing

  • pnpm check:types
  • pnpm exec vitest run src/internal/NonceSet.test.ts src/tempo/Attribution.test.ts src/server/Mppx.test.ts
  • pnpm exec vitest run src/tempo/server/Charge.test.ts

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/mppx@232

commit: bb3d827

@brendanjryan
Copy link
Copy Markdown
Collaborator Author

going to close this for now -- we are considering other approaches including increasing memo size so that we can pack the full challengeId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant