perf(verification): bound full runs and reduce test setup - #72
Merged
Merged
Conversation
Enforce a 150-second whole-run deadline, remove duplicate static checks, and run safe static checks concurrently. Match test fixtures to the resource their assertions observe while keeping product coverage and full-gate evidence explicit. Record measured gains and rejected scheduling candidates.
wefio
marked this pull request as ready for review
September 24, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更描述
What:把
agent:verify的 150 秒设置落实为整次调用的截止时间,并降低完整验证中重复检查和测试资源准备的开销。Why:原实现对串行子命令分别计时,整次运行可能超过 150 秒;静态检查重复执行、部分测试建立了断言并不需要的文件或 Git 仓库。
Changes:
干净检出(Node v24.19.0 / Windows)上的
agent:verify --full --require-clean覆盖本 PR 的 31 个改动文件:13 个阻断检查、1536 个产品测试全部通过,整次调用耗时 93.3 秒。verify:product-ci通过同一批 1536 个测试,整体行覆盖率 85.16%;verify:static、docs:check、git diff --check也通过。实验中的 77 秒结果来自另一工作树,不用作本提交的计时结论。未验证项
Not verified:未运行 Windows chaos 套件,也未在非 Windows 平台验证。Research characterization 和 Node 22 compatibility 已在 CI 通过。夹具缩减在单文件上有可重复收益,但现有配对全量样本未证明它单独带来整体提速。150 秒是失败截止时间,不保证所有机器都能在截止前完成全部检查。
完成检查项
本地质量检查
npm run verify:static通过npm run test:product通过(完整agent:verify已运行同一命令)check:lock通过verify:packages通过npm run docs:check通过;决策记录已更新## 未验证项已填写complexity:gate通过RCP(Repository Control Plane)
agent:verify --full --require-clean <改动路径>通过,receipt 覆盖全部 31 个文件和改动路由nmg-rcp forge-status --pr 72 --json的已运行 checks 全为 SUCCESS;Windows chaos 按配置 SKIPPEDCI 完成确认
nmg-rcp forge-status的All checks passed为 SUCCESS