Use subtree of webui library instead of submodule - #56
Closed
bminer wants to merge 3 commits into
Closed
Conversation
git-subtree-dir: v2/webui git-subtree-split: 94a8cfbad041f44c576c62d9723cc0efa846330a
Member
|
I did a more complete changes in this branch https://github.com/webui-dev/go-webui/tree/subtree , I already tested it and looks fine to me. Please let me know if I miss something, or if this PR is more complete than the branch. |
Contributor
Author
|
Closing for now. I will try out the new go-webui version here shortly! |
Contributor
Author
|
Yeah, to be clear, I think your subtree branch is a more complete set of commits, so closing this PR in favor of yours. How do you like this approach so far? Does |
Member
|
Yes, it does work easier than before, thank you for the proposition @bminer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #55, this PR attempts to replace submodules with subtree so that
go getonly needs to be performed on the Go module without any symlinks needed to the webui C/C++ library.See https://www.atlassian.com/git/tutorials/git-subtree for a nice tutorial.
I think perhaps we can add more commits to this PR to remove the unneeded
sync-webuiprogram, etc.Would love to get some feedback on this. I'll try it out to see if it works!
Basically just did the following: