Skip to content

Use subtree of webui library instead of submodule - #56

Closed
bminer wants to merge 3 commits into
webui-dev:mainfrom
bminer:main
Closed

Use subtree of webui library instead of submodule#56
bminer wants to merge 3 commits into
webui-dev:mainfrom
bminer:main

Conversation

@bminer

@bminer bminer commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Per #55, this PR attempts to replace submodules with subtree so that go get only needs to be performed on the Go module without any symlinks needed to the webui C/C++ library.

See https://www.atlassian.com/git/tutorials/git-subtree for a nice tutorial.

I think perhaps we can add more commits to this PR to remove the unneeded sync-webui program, etc.

Would love to get some feedback on this. I'll try it out to see if it works!

Basically just did the following:

git rm v2/webui
git commit
git subtree add --prefix v2/webui https://github.com/webui-dev/webui.git 94a8cfbad041f44c576c62d9723cc0efa846330a --squash

@AlbertShown

Copy link
Copy Markdown
Member

I did a more complete changes in this branch https://github.com/webui-dev/go-webui/tree/subtree , I already tested it and looks fine to me.

Please let me know if I miss something, or if this PR is more complete than the branch.

@bminer

bminer commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing for now. I will try out the new go-webui version here shortly!

@bminer bminer closed this Jul 30, 2026
@bminer

bminer commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Yeah, to be clear, I think your subtree branch is a more complete set of commits, so closing this PR in favor of yours. How do you like this approach so far? Does go get work out of the box now?

@AlbertShown

Copy link
Copy Markdown
Member

Yes, it does work easier than before, thank you for the proposition @bminer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants