Skip to content

Conversation

@hilja
Copy link

@hilja hilja commented Dec 19, 2025

Not 100% if pkgScripts is how you tell it to treat program as a script. These obviously fail.

#1399

@hilja
Copy link
Author

hilja commented Dec 19, 2025

I think a whole category of tests are missing, the pnpm program ... is covered really well, but there's just the basic case for pnpm script ... and node -r script.

@webpro
Copy link
Member

webpro commented Dec 20, 2025

Feel free to add more cases. Please keep in mind I like to keep it a bit concise/sensible/maintainable, there's no need to test every possible case out there (e.g. that list of bun [command] cases are a bit much imho).

Cases that won't be fixed in this round are still useful to know about and we can t.skip.

@webpro webpro force-pushed the main branch 4 times, most recently from f4844ad to 0faa3b8 Compare December 20, 2025 12:55
webpro added a commit that referenced this pull request Dec 21, 2025
@webpro
Copy link
Member

webpro commented Dec 21, 2025

Fixed a few cases. Forgot to add: Knip does not aim to implement all the features all the various tools might have. It's on the basis of best-effort. That said, feel free to dive in!

webpro added a commit that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants