Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeDoc markdown theme/router integration to generate more accurate anchored URLs (used for type-map.json) and regenerates the affected webpack v5 API docs output accordingly.
Changes:
- Add a custom
buildAnchorsimplementation inDocKitRouterto generate consistent member anchors (and.html#...URLs) using the same title formatting as the theme. - Refactor
memberTitleinto a reusable helper and suppress rendering of type-parameter sections in the markdown theme partials. - Regenerate markdown docs to remove repetitive “Type Parameters” blocks and adjust a few emitted type annotations/links.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/theme/router.mjs | Adds custom anchor-building logic for reflections to improve anchored URLs/type-map generation. |
| plugins/theme/partials/index.mjs | Extracts getMemberTitle, wires it into partials, and suppresses typeParametersList output. |
| pages/v5.x/webpack/namespaces/util/namespaces/serialization.md | Removes emitted per-type-parameter subsections from generated docs. |
| pages/v5.x/webpack/namespaces/util/namespaces/runtime.md | Removes emitted type-parameter subsections for generics in generated docs. |
| pages/v5.x/webpack/namespaces/util/namespaces/comparators.md | Removes emitted per-type-parameter subsections from generated docs. |
| pages/v5.x/webpack/namespaces/util/index.md | Removes emitted type-parameter subsections in class/method docs and generic helpers. |
| pages/v5.x/webpack/namespaces/sharing.md | Removes emitted per-type-parameter subsection from generated docs. |
| pages/v5.x/webpack/namespaces/ModuleFilenameHelpers.md | Removes emitted per-type-parameter subsection from generated docs. |
| pages/v5.x/webpack/namespaces/library.md | Removes emitted type-parameter subsections from generated docs. |
| pages/v5.x/webpack/namespaces/javascript.md | Removes emitted type-parameter subsections from generated docs. |
| pages/v5.x/webpack/namespaces/dependencies.md | Adjusts generated type annotations (e.g., TRANSITIVE now shown as symbol). |
| pages/v5.x/webpack/namespaces/container.md | Removes emitted per-type-parameter subsection from generated docs. |
| pages/v5.x/index.md | Updates the loader table entries/badges for pug loader references. |
| pages/v5.x/globals.md | Removes emitted type-parameter subsections and updates a few generated type annotations. |
| pages/v5.x/_media/WORKING_GROUP.md | Updates the working group members list details. |
| HEAD_COMMIT | Updates the tracked head commit hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.