declare key as a var so it complies with strict mode

[liuhelen10]

Fixes issue defined here

[liuhelen10]

@coreh do you mind reviewing?

[coreh]

Oops! Sorry, hadn't seen your other issue, I've been a bit MiA on GitHub lately. 😕

I'm no longer a member of the webmodules org, so I no longer have commit access :(

I was going to hand over the npm package over to @wilddeer, the original author of the lib, but looks like I dropped the ball on that one too. 😕 Looks like he published the updated package under stickyfilljs. Here's his repo: https://github.com/wilddeer/stickyfill/

Is it still affected by this issue?

@wilddeer if you'd like I can still make that transfer

[liuhelen10]

Unfortunately the package owned by @wilddeer breaks when included in apps that use server-side rendering, so i've been continuing to use this one.

What's the best next step @coreh ? Is this package no longer going to be maintained? Should I open a new issue against https://github.com/wilddeer/stickyfill/ ?

[coreh]

@liuhelen10 I've merged this locally on my machine and — since I still have owner access to the package — published version 1.1.1-strict to NPM.

I didn't go for, say, 1.1.2 because there is already a version with that number from the original author, and it wouldn't be exactly the same as this patched version. (Perhaps they still want to publish it under the actual stickyfill name, and I don't want to "use up" that version).

@wilddeer I've added you as an owner to the stickyfill package on npm. I guess better late than never? 🙇 Sorry for taking so long

[liuhelen10]

great thank you!! so is this npm installable now? i don't see it in the release log

[coreh]

Yep. npm install --save stickyfill@1.1.1-strict from your project should work.