Change RegisteredTool#inputSchema type from DOMString to object - #241
Merged
domfarolino merged 2 commits intoAug 14, 2026
Merged
Conversation
domfarolino
approved these changes
Aug 12, 2026
beaufortfrancois
added a commit
to beaufortfrancois/model-context-tool-inspector
that referenced
this pull request
Aug 13, 2026
Ensure `inputSchema` is serialized to a string when returned as an object from `document.modelContext.getTools()`, aligning with the updated WebMCP specification and Chromium implementation. References: - https://chromium-review.googlesource.com/c/chromium/src/+/8248081 - webmachinelearning/webmcp#241
This was referenced Aug 13, 2026
fix: handle RegisteredTool.inputSchema as an object
beaufortfrancois/model-context-tool-inspector#34
Merged
Merged
domfarolino
force-pushed
the
inputSchemaObject
branch
from
August 14, 2026 15:13
c1bbb5b to
dda8d75
Compare
Collaborator
domfarolino
approved these changes
Aug 14, 2026
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 20, 2026
This CL updates the WebIDL definition for RegisteredTool.inputSchema from DOMString to object to align with the WebMCP specification: webmachinelearning/webmcp#241 In Blink, JSONStringToScriptObject() is used in ModelContext::OnGetScriptToolsCompleted() to parse the mojo string into a ScriptObject when constructing the RegisteredTool results. Web platform tests in external/wpt/webmcp/imperative/ are updated to expect inputSchema as a JavaScript object rather than a serialized JSON string. Bug: 489045948 Change-Id: I7a28b36d725c85e24726708aecee4cd9f3cbb476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8248081 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1682945}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 20, 2026
This CL updates the WebIDL definition for RegisteredTool.inputSchema from DOMString to object to align with the WebMCP specification: webmachinelearning/webmcp#241 In Blink, JSONStringToScriptObject() is used in ModelContext::OnGetScriptToolsCompleted() to parse the mojo string into a ScriptObject when constructing the RegisteredTool results. Web platform tests in external/wpt/webmcp/imperative/ are updated to expect inputSchema as a JavaScript object rather than a serialized JSON string. Bug: 489045948 Change-Id: I7a28b36d725c85e24726708aecee4cd9f3cbb476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8248081 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1682945}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 20, 2026
This CL updates the WebIDL definition for RegisteredTool.inputSchema from DOMString to object to align with the WebMCP specification: webmachinelearning/webmcp#241 In Blink, JSONStringToScriptObject() is used in ModelContext::OnGetScriptToolsCompleted() to parse the mojo string into a ScriptObject when constructing the RegisteredTool results. Web platform tests in external/wpt/webmcp/imperative/ are updated to expect inputSchema as a JavaScript object rather than a serialized JSON string. Bug: 489045948 Change-Id: I7a28b36d725c85e24726708aecee4cd9f3cbb476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8248081 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1682945}
12 tasks
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Aug 21, 2026
This reverts commit ec5ace9. Reason for revert: A packaging update failure with the "WebMCP - Model Context Tool Inspector" extension is currently blocking Chrome Canary users from interacting with WebMCP tools. Reverting this change temporarily to unblock users during my upcoming OOO; the CL will be relanded once the extension update is published. Original change's description: > [WebMCP] Expose RegisteredTool.inputSchema as an object > > This CL updates the WebIDL definition for RegisteredTool.inputSchema > from DOMString to object to align with the WebMCP specification: > webmachinelearning/webmcp#241 > > In Blink, JSONStringToScriptObject() is used in > ModelContext::OnGetScriptToolsCompleted() to parse the mojo string > into a ScriptObject when constructing the RegisteredTool results. > > Web platform tests in external/wpt/webmcp/imperative/ are updated to > expect inputSchema as a JavaScript object rather than a serialized > JSON string. > > Bug: 489045948 > Change-Id: I7a28b36d725c85e24726708aecee4cd9f3cbb476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8248081 > Reviewed-by: Dominic Farolino <dom@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1682945} Bug: 489045948 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id3fbbf9e22d902cc9341bd14fae78927582e1cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8276309 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1683806}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 21, 2026
This reverts commit ec5ace9a94e9b4610a8f0ed1b9548ced902c6315. Reason for revert: A packaging update failure with the "WebMCP - Model Context Tool Inspector" extension is currently blocking Chrome Canary users from interacting with WebMCP tools. Reverting this change temporarily to unblock users during my upcoming OOO; the CL will be relanded once the extension update is published. Original change's description: > [WebMCP] Expose RegisteredTool.inputSchema as an object > > This CL updates the WebIDL definition for RegisteredTool.inputSchema > from DOMString to object to align with the WebMCP specification: > webmachinelearning/webmcp#241 > > In Blink, JSONStringToScriptObject() is used in > ModelContext::OnGetScriptToolsCompleted() to parse the mojo string > into a ScriptObject when constructing the RegisteredTool results. > > Web platform tests in external/wpt/webmcp/imperative/ are updated to > expect inputSchema as a JavaScript object rather than a serialized > JSON string. > > Bug: 489045948 > Change-Id: I7a28b36d725c85e24726708aecee4cd9f3cbb476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8248081 > Reviewed-by: Dominic Farolino <dom@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1682945} Bug: 489045948 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id3fbbf9e22d902cc9341bd14fae78927582e1cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8276309 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1683806}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #237 (comment),
ModelContextTool#inputSchemawas defined as anobjectduring registration, butRegisteredTool#inputSchemareturned a stringified JSON schema (DOMString) fromgetTools().This change aligns
RegisteredTool#inputSchemato be anobject(JavaScript object), matchingModelContextTool#inputSchemaand the MCP Tool specification.Hopefully we'll apply the same reasoning to
executeTool(myTool, {})instead ofexecuteTool(myTool, '{}')in #226Preview | Diff