Repository navigation
ci: prove the whole supported PHP range, 8.2 to 8.5 - #17
Merged
Merged
Conversation
composer.json claims php >=8.2 with no upper bound, but CI ran 8.4 only. So three of the four versions in the supported range, including the newest, were never executed: ">=8.2" was a claim rather than a tested fact, and nothing would have caught syntax or behaviour that needs a later version. Added a compat job over 8.2, 8.3 and 8.5, which together with the 8.4 gate covers the range. The test job is left exactly as it was, name included, because the branch ruleset requires a status check named exactly "test". Turning it into a matrix would publish "test (8.2)" and the required context would never appear again, blocking every future merge. The compat job is derived from the test job rather than written fresh, so it keeps the same services, extensions, environment, coverage and steps and cannot drift from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer.jsonclaimsphp: >=8.2with no upper bound, but CI ran 8.4 only. Three of the four versions in the supported range, including the newest, were never executed.>=8.2was a claim rather than a tested fact, and nothing would have caught syntax or behaviour needing a later version.Change
A
compatjob over 8.2, 8.3 and 8.5, which together with the 8.4 gate covers the declared range.Two deliberate choices
The
testjob is untouched, name included. The branch ruleset requires a status check named exactlytest. Turning it into a matrix would publishtest (8.2),test (8.3)and so on, and the requiredtestcontext would never appear again, blocking every future merge on this repo. Adding a separate job avoids that entirely.The
compatjob is derived from thetestjob, not written fresh, so it carries the same services, extensions, environment, coverage and steps and cannot drift from it.I first had it run with
coverage: none, reasoning that collecting coverage once on the gate was enough. That failed every leg:phpunit.xml.distconfigures coverage reports, so with no driver PHPUnit emits a test-runner warning and exits 1 even though all tests pass. Worth recording, because it looks like a free speed-up and is not.What this may surface
If a leg fails, that is the point of the change: it means the package does not actually support a version it claims to. I would rather that show up here than in someone's install.