Repository navigation
ci: prove PHP 8.5, and make the required check reachable - #74
Merged
Merged
Conversation
Two things, both about the gate rather than the code.
The matrix covered 8.2, 8.3 and 8.4. composer.json claims php >=8.2 with
no upper bound, so 8.5 is in the supported range and nothing ran against
it. Added it.
The branch ruleset requires a status check named exactly "test", and no
such check has ever been published. The matrix job was named
"test / php ${{ matrix.php }} / ${{ matrix.os }}", so what appears on a
pull request is "test / php 8.2 / ubuntu-latest" and so on. A bare
"test" never existed, so the required check could never be satisfied and
every merge needed an admin bypass to get through. PR #73 went in that
way.
Renamed the matrix job to "tests" and added a small job that carries the
name "test" and fails unless every leg succeeded. The ruleset now gates
on the real result, and the supported versions can change without
touching it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both about the gate rather than the code.
1. PHP 8.5 was never tested
The matrix covered 8.2, 8.3 and 8.4.
composer.jsonclaimsphp >=8.2with no upper bound, so 8.5 is in the supported range and nothing ran against it. Added.2. The required status check has never been reachable
This is the one worth attention. The branch ruleset requires a check named exactly
test, and no such check has ever been published.The matrix job was named
test / php ${{ matrix.php }} / ${{ matrix.os }}, so what actually appears on a pull request is:A bare
testis not among them. So the required check could never be satisfied, and every merge on this repo has needed an admin bypass to get through - #73 went in that way. The ruleset has been decorative rather than protective.Renamed the matrix job to
testsand added a small job that carries the nametestand fails unless every leg succeeded:The ruleset now gates on the real result, and the supported PHP versions can change without anyone having to remember to edit it.
Note on the contexts
The matrix contexts are renamed from
test / php X / ostotests / php X / os. Nothing required them, so nothing breaks. If you have anything outside the ruleset keyed to the old names, this is the change to know about.cachehas the same ruleset requirement but publishes a genuine non-matrixtestjob, so it was never affected.autoloaduses this same aggregating shape.