Repository navigation
Fix/linux hud menu clipping - #945
abdu11ahbaig wants to merge 1 commit into
Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. | |
| Linked Issues check | The linked issue is unrelated to this pull request. Issue #931 concerns repeated, low-pitched microphone audio on Windows, while this pull request fixes Linux HUD menu clipping. |
Link an issue that tracks the Linux HUD menu clipping problem, or remove the unrelated issue link and explain why no related issue exists. |
✅ Passed checks (3 passed)
-
Check name Status Explanation Out of Scope Changes check ✅ Passed The one-line change in electron/windows.ts directly supports the stated objective of restoring Linux HUD expansion for dropdown menus. No unrelated changes are described. Title check ✅ Passed The title clearly identifies the main change: fixing Linux HUD menu clipping. It is concise and related to the pull request changes. Description check ✅ Passed The description includes the required sections, explains the Linux HUD clipping issue, identifies the bug-fix type, links an issue, and provides testing steps. It does not include screenshots, but it …
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create PR with unit tests
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
0948979 to
79946dc
Compare
79946dc to
f990a8a
Compare
Description
Fixes dropdown menus (Camera, Microphone, Language, Timer) rendering clipped/behind the recording bar on Linux by restoring HUD window expansion for popovers.
Motivation
On Linux, the HUD overlay window doesn't support mouse-passthrough, so it stays compact (160px) and is supposed to expand (540px) when a popover opens. A leftover
process.platform !== "linux"guard insetHudOverlayMousePassthrough(electron/windows.ts) made that expansion dead code on Linux.. the only platform that hits it, so the window never grew and popover content got clipped behind the recording bar. Removing the guard restores the intended behavior.Type of Change
Related Issue(s)
Fixes #931
Screenshots / Video
Testing Guide
Checklist
Summary by CodeRabbit