NFC-47 NFC support for web-eid example#83
Merged
mrts merged 1 commit intoweb-eid-mobilefrom Oct 24, 2025
Merged
Conversation
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
102c405 to
5108d00
Compare
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
2 times, most recently
from
1da9ec5 to
d3edcb7
Compare
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
2 times, most recently
from
b519373 to
81dea4d
Compare
SanderKondratjevNortal
force-pushed
the
web-eid-mobile
branch
from
323499f to
b18fa03
Compare
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
81dea4d to
44ebf84
Compare
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
44ebf84 to
123e619
Compare
mrts
requested changes
Oct 14, 2025
example/src/main/java/eu/webeid/example/security/WebEidAjaxLoginProcessingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/WebEidAjaxLoginProcessingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/WebEidAjaxLoginProcessingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/WebEidAjaxLoginProcessingFilter.java
Outdated
Show resolved
Hide resolved
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
123e619 to
379d320
Compare
mrts
requested changes
Oct 16, 2025
Member
mrts
left a comment
mrts
left a comment
There was a problem hiding this comment.
Looks good to me now apart from the suggested changes, thanks for your great work!
As discussed, also consider making mobile code configurable both to make it easier to discern and possibly serve a real business need not to use it in certain circumstances.
example/src/main/java/eu/webeid/example/security/ui/WebEidLoginPageGeneratingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/ui/WebEidLoginPageGeneratingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/ui/WebEidLoginPageGeneratingFilter.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/security/ui/WebEidLoginPageGeneratingFilter.java
Outdated
Show resolved
Hide resolved
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
379d320 to
4b02d73
Compare
mrts
requested changes
Oct 21, 2025
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
4b02d73 to
7c72ee0
Compare
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
SanderKondratjevNortal
force-pushed
the
NFC-47
branch
from
7c72ee0 to
f576915
Compare
|
mrts
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev sander.kondratjev@nortal.com