Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2179.
What changes
BatchObjectReturn.errorsis keyed by the object's original index, but the rate-limit re-add path filtered_all_responsesby its list position. From the second chunk onward those two numbers differ, so the re-added object'sErrorObjectstayed in_all_responsesafter its retry succeeded, while a successful object's entry was dropped instead. The same line read the deprecatedall_responsesproperty, so a batch that never touched the deprecated attribute still emittedDep020._all_responses._all_responsesdirectly instead of going through the deprecated property.batch_size=2, the first object of the second chunk rate-limited once.Testing
main: the retried object'sErrorObjectis still in_all_responses(assert False), andDep020is emitted. It passes with the change.mock_tests/test_batch.py: 6 passed.