Skip to content

Add support for Python 3.15 and drop 3.10 - #2258

Merged
dirkkul merged 5 commits into
dev/1.41from
python_315
Nov 13, 2026
Merged

dirkkul merged 5 commits into
dev/1.41from
python_315

Conversation

@dirkkul

@dirkkul dirkkul commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator
  • python 3.10 is EOL
  • added 3.15 to setup.cfg and CI support
  • Rename profiling/ to profiling_tests/: Python 3.15 adds a stdlib profiling package that cProfile imports, and the repo directory shadowed it whenever the repo root was on sys.path.

@dirkkul
dirkkul requested a review from a team as a code owner November 13, 2026 13:30
Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:30

@orca-security-eu orca-security-eu Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new Python 3.15 journey-test entry still uses the hard-coded Python 3.11 interpreter, so it duplicates existing coverage rather than testing 3.15.

1 open issue
What changed in this PR

Updates the Weaviate Python client for Python 3.15 and raises the minimum supported version to Python 3.11.

Changes:

  • Updates package requirements, documentation, and typing code for the new Python baseline.
  • Adds Python 3.15 CI matrix entries and interpreter-specific development dependencies.
  • Renames profiling/ to profiling_tests/ to avoid shadowing Python 3.15’s standard-library package.
File Description
weaviate/​util.py Simplifies scalar UUID type checking.
weaviate/​collections/​classes/​internal.py Removes obsolete typing-import compatibility logic.
weaviate/​collections/​classes/​grpc.py Narrows the BM25 operator annotation.
setup.cfg Requires Python 3.11 or newer.
requirements-devel.txt Adds Python 3.15 dependency pins and updates typing extensions.
README.rst Updates the documented Python baseline.
profiling_tests/​test_sphere.py Relocates Sphere dataset profiling tests.
profiling_tests/​test_shutdown.py Relocates batch-import shutdown tests.
profiling_tests/​test_refs.py Relocates reference stress tests.
profiling_tests/​test_profiling.py Updates example commands for the renamed directory.
profiling_tests/​test_import_and_query.py Relocates import and query performance tests.
profiling_tests/​pyspy.py Relocates the query profiling script.
profiling_tests/​constants.py Relocates profiling image fixtures.
profiling_tests/​conftest.py Updates dataset lookup paths after the rename.
profiling_tests/​__init__.py Preserves package structure under the new name.
packages/​web/​pyproject.toml Raises the web package’s Python minimum to 3.11.
docs/​index.rst Updates the documented Python baseline.
docs/​changelog.rst Records Python 3.10 removal and Python 3.15 support.
.github/​workflows/​main.yaml Updates Python matrices and coverage-upload conditions.

Review effort: Balanced

Comment thread .github/workflows/main.yaml Resolved
@weaviate-proov-pr-reviewer

Copy link
Copy Markdown

Proov triage

Check Result
What this PR does Drops Python 3.10 support (requires-python >=3.11), adds 3.15 to CI and deps, renames profiling/ to profiling_tests/ to avoid shadowing the new stdlib module, and simplifies typing now that 3.10 is gone.
Risk 🟠 Amber — Changes public requires-python and runtime isinstance/typing behaviour; contained but user-visible.

Advisory, generated by Proov (deepseek-v4.1-flash + kimi-k3) at 536e1de. The review follows.

@weaviate-proov-pr-reviewer

Copy link
Copy Markdown

Proov review: approve-with-comments

Recommendation: Approve

The _to_beacons rewrite is safe: isinstance(uuids, UUID) works because UUID is an unsubscripted Union[str, uuid.UUID], a pattern already shipped at weaviate/collections/iterator.py:41 — the apparent reference regressions were refuted. Nothing blocks merge.

  • weaviate/collections/classes/grpc.py:646 — the BM25OperatorOptions.operator narrowing and the _to_beacons rewrite aren't mentioned in the PR description; name them so reviewers know the diff's full scope.
  • weaviate/util.py:673 — the _to_beacons str/UUID/list cross-product has no unit test; only integration tests reach it, so a regression in this pure function surfaces only in the slowest job. Add a table case to test/test_util.py.
  • profiling_tests/conftest.py:22 — no workflow runs profiling_tests/, so the rename's path fix and the 3.15 import-shadowing fix it exists for are unverified. Add a collection-only smoke job or note it's manual-only.

17 CI checks are still in progress — wait for green before merging.

review-branch@c31ceb2 · deepseek-v4.1-flash + kimi-k3 · tests not run · advisory

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev/1.41@dd9956d). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.41    #2258   +/-   ##
===========================================
  Coverage            ?   92.40%           
===========================================
  Files               ?      311           
  Lines               ?    23601           
  Branches            ?        0           
===========================================
  Hits                ?    21809           
  Misses              ?     1792           
  Partials            ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul
dirkkul merged commit e9c6ca8 into dev/1.41 Nov 13, 2026
170 checks passed
@dirkkul
dirkkul deleted the python_315 branch November 13, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants