Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions integration/test_rbac.py
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,7 @@ def test_get_assigned_users_db(client_factory: ClientFactory, request: SubReques
permissions=Permissions.roles(role="test", read=True),
)

client.users.db.delete(user_id=names)
client.users.db.create(user_id=names)

client.users.db.assign_roles(user_id=names, role_names=names)
Expand All @@ -738,6 +739,13 @@ def test_get_assigned_users_db(client_factory: ClientFactory, request: SubReques
assert assigned_users[0].user_id == names
assert assigned_users[0].user_type == UserTypes.DB_DYNAMIC

# An OIDC user with the same id keeps the role when the db user's is revoked.
client.users.oidc.assign_roles(user_id=names, role_names=names)
client.users.db.revoke_roles(user_id=names, role_names=names)
assigned_users = client.roles.get_user_assignments(names)
assert len(assigned_users) == 1
assert assigned_users[0].user_type == UserTypes.OIDC

client.roles.delete(names)
client.users.db.delete(user_id=names)

Expand Down
2 changes: 1 addition & 1 deletion weaviate/users/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def resp(res: Response) -> None:
response_callback=resp,
method=self._connection.post,
path=path,
weaviate_object={"roles": roles},
weaviate_object=payload,
error_msg=f"Could not revoke roles {roles} from user {user_id}",
status_codes=_ExpectedStatusCodes(ok_in=[200], error="Revoke roles from user"),
)
Expand Down
Loading