Skip to content

fix(generative): send AWS stop_sequences through to the gRPC request #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix(generative): send AWS stop_sequences through to the gRPC request #2131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/collection/test_classes_generative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def test_generative_parameters_images_parsing(
target_model="arn:aws:sagemaker:us-west-2:123456789012:model/text-to-image",
target_variant="variant-1",
temperature=0.5,
stop_sequences=["\n"],
)._to_grpc(
_GenerativeConfigRuntimeOptions(
return_metadata=True, images=[LOGO_ENCODED], image_properties=["image"]
Expand All @@ -121,6 +122,7 @@ def test_generative_parameters_images_parsing(
target_model="arn:aws:sagemaker:us-west-2:123456789012:model/text-to-image",
target_variant="variant-1",
temperature=0.5,
stop_sequences=base_pb2.TextArray(values=["\n"]),
images=base_pb2.TextArray(values=[LOGO_ENCODED]),
image_properties=base_pb2.TextArray(values=["image"]),
),
Expand Down
7 changes: 5 additions & 2 deletions weaviate/collections/classes/generative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,10 @@ def _to_grpc(self, opts: _GenerativeConfigRuntimeOptions) -> generative_pb2.Gene
target_variant=self.target_variant,
temperature=self.temperature,
max_tokens=self.max_tokens,
stop_sequences=_to_text_array(self.stop_sequences),
images=_to_text_array(opts.images),
image_properties=_to_text_array(opts.image_properties),
# TODO - add top_k, top_p & stop_sequences here when added to server-side proto
# TODO - add top_k & top_p here when added to server-side proto
# Check the latest availble version of `grpc/proto/v1/generative.proto` (see GenerativeAWS) in the server repo
),
)
Expand Down Expand Up @@ -587,6 +588,7 @@ def aws(
target_model: Optional[str] = None,
target_variant: Optional[str] = None,
temperature: Optional[float] = None,
stop_sequences: Optional[List[str]] = None,

@dirkkul dirkkul Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this field here? We do not want to update deprecated factories

) -> _GenerativeConfigRuntime:
"""Create a `_GenerativeAWS` object for use when performing dynamic AI generation using the `generative-aws` module.

Expand All @@ -602,6 +604,7 @@ def aws(
target_model: The target model to use. Defaults to `None`, which uses the server-defined default
target_variant: The target variant to use. Defaults to `None`, which uses the server-defined default
temperature: The temperature to use. Defaults to `None`, which uses the server-defined default
stop_sequences: The stop sequences to use. Defaults to `None`, which uses the server-defined default
"""
return _GenerativeAWS(
model=model,
Expand All @@ -616,7 +619,7 @@ def aws(
temperature=temperature,
top_k=None,
top_p=None,
stop_sequences=None,
stop_sequences=stop_sequences,
)

@staticmethod
Expand Down