Improve implementation of Hosting Policy page#1121
Conversation
|
Deployment previews on netlify for branch
|
Bug: T422593
outdooracorn
left a comment
There was a problem hiding this comment.
Managed to do a quick review.
I would comment out all the custom CSS and see how far you can get with Vuetify-native CSS classes. Reach out for collaboration if that is proving difficult. If we have to add custom CSS we should also write a comment explaining why it was necessary.
outdooracorn
left a comment
There was a problem hiding this comment.
Another quick review with some nitpicks. We are getting there :D
There was a problem hiding this comment.
Sorry, I wasn't very clear that we should remove all the strong and em elements unless the text is conveying importance or emphasis. Ask yourself, "if I was reading this sentence out loud, would I shout or otherwise emphasizes that part of the sentence?". If not, then the bold and/or italic styling should be done via CSS classes.
I've added some suggestions to provide more examples to go off, but I haven't done them all.
I went through it and i think i wouldn't shout for any of those text. probably not emphasize as well so i removed them all and used the css classes from your suggestions. |
outdooracorn
left a comment
There was a problem hiding this comment.
This is looking good! I've spotted two minor changes to be resolved, but then I'm happy for this to be shown to Anton to make sure he is still happy after these changes, and then merged.
Removing my changes requested so that it's not being blocked if you want to ship this on Monday (once Anton has verified).
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
outdooracorn
left a comment
There was a problem hiding this comment.
I think we are nearly there! Two small comments.
Dat's away and his comments have been addressed
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
outdooracorn
left a comment
There was a problem hiding this comment.
Latest changes look good 👍. I've noticed two more places than need the Unicode emoji being removed.
outdooracorn
left a comment
There was a problem hiding this comment.
PM has reviewed the preview and approved
v-alertinstead of custom HTML and CSS.Assessment of size and loadsection that show links more clearly.v-iconinstead of Unicode emojis so that the icons are consistent across devices.strong,em, anduelements in favour of native Vuetify2 classes.Bug: T422593