Skip to content

Improve implementation of Hosting Policy page#1121

Merged
outdooracorn merged 13 commits into
mainfrom
T422593
Apr 28, 2026
Merged

Improve implementation of Hosting Policy page#1121
outdooracorn merged 13 commits into
mainfrom
T422593

Conversation

@rosalieper
Copy link
Copy Markdown
Contributor

@rosalieper rosalieper commented Apr 13, 2026

  • Remove all custom CSS in favour of native Vuetify2 classes.
  • Use v-alert instead of custom HTML and CSS.
  • Use a color for the Assessment of size and load section that show links more clearly.
  • Use v-icon instead of Unicode emojis so that the icons are consistent across devices.
  • Remove incorrect use of strong, em, and u elements in favour of native Vuetify2 classes.

Bug: T422593

@github-actions
Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1121/merge will be at the following locations (when build is done):

Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to do a quick review.

I would comment out all the custom CSS and see how far you can get with Vuetify-native CSS classes. Reach out for collaboration if that is proving difficult. If we have to add custom CSS we should also write a comment explaining why it was necessary.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another quick review with some nitpicks. We are getting there :D

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't very clear that we should remove all the strong and em elements unless the text is conveying importance or emphasis. Ask yourself, "if I was reading this sentence out loud, would I shout or otherwise emphasizes that part of the sentence?". If not, then the bold and/or italic styling should be done via CSS classes.

I've added some suggestions to provide more examples to go off, but I haven't done them all.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
@rosalieper
Copy link
Copy Markdown
Contributor Author

"if I was reading this sentence out loud, would I shout or otherwise emphasizes that part of the sentence?"

I went through it and i think i wouldn't shout for any of those text. probably not emphasize as well so i removed them all and used the css classes from your suggestions.

Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I've spotted two minor changes to be resolved, but then I'm happy for this to be shown to Anton to make sure he is still happy after these changes, and then merged.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
@outdooracorn outdooracorn dismissed their stale review April 17, 2026 13:01

Removing my changes requested so that it's not being blocked if you want to ship this on Monday (once Anton has verified).

Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
dati18
dati18 previously requested changes Apr 22, 2026
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are nearly there! Two small comments.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
@outdooracorn outdooracorn dismissed dati18’s stale review April 23, 2026 15:21

Dat's away and his comments have been addressed

rosalieper and others added 3 commits April 24, 2026 09:38
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good 👍. I've noticed two more places than need the Unicode emoji being removed.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this now. Let's get PM review before merging.

Comment thread src/components/Pages/HostingPolicy.vue Outdated
Comment thread src/components/Pages/HostingPolicy.vue Outdated
@outdooracorn outdooracorn changed the title UI: Refactor Hosting Policy page Improve code quality of Hosting Policy page Apr 27, 2026
@outdooracorn outdooracorn changed the title Improve code quality of Hosting Policy page Improve implementation of Hosting Policy page Apr 27, 2026
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PM has reviewed the preview and approved

@outdooracorn outdooracorn merged commit fbbf689 into main Apr 28, 2026
7 checks passed
@outdooracorn outdooracorn deleted the T422593 branch April 28, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants