Update to laravel/framework:^11.51#1083
Merged
Merged
Conversation
1065c9d to
277d06e
Compare
277d06e to
206aabd
Compare
da2a7d6 to
36c2e99
Compare
``` docker run --rm -it -v $PWD:/app -u $(id -u):$(id -g) composer:2.9.2 --ignore-platform-req=ext-pcntl require --with-all-dependencies laravel/framework:^11.51 ``` Bug: T426075
Add mariadb-client to our api docker image This is needed by Laravel to run schema:dump command Also add custom mariadb-client config to enable no TLS functionality Bug: T426075
Required becuase Laravel 11 handles modifying columns differently [1] Created by running all the existing migrations followed by `php artisan schema:dump --prune` [1]: https://laravel.com/docs/11.x/upgrade#modifying-columns Bug: T426075
These files are installed automatically when installing with `php artisan passport:install` if they don't already exist. The autogenerated files don't conform to our code style and so fails linting. Keeping correctly styled migrations files in `database/migrations/` resolves this issue. Bug: T426075
As per the update guide [1], this should be comparable to the `mysql` driver. Keep the options the same as the in the database docs [2]. The connection name remains `mysql` because we found this is used in an unknown number of places. We saw most of the tests fail when renaming this to `mariadb` but we don't want to investigate this now. We also thought that we should name this something like technology agnostic and with clear purpose such as `platform_api_db`. [1]: https://laravel.com/docs/11.x/upgrade#dedicated-mariadb-driver [2]: https://laravel.com/docs/11.x/database#read-and-write-connections Bug: T426075
As per the update guide [1], Doctrine DBAL related classes and methods have been removed. Remove `doctrine/dbal` as we currently don't use it in the Platform API. ``` docker run --rm -it -v $PWD:/app -u $(id -u):$(id -g) composer:2.9.2 --ignore-platform-req=ext-pcntl remove doctrine/dbal ``` [1]: https://laravel.com/docs/11.x/upgrade#doctrine-dbal-removal Bug: T426075
982eaef to
ae43818
Compare
tarrow
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T360023