Repository navigation
ci: fix the dashboard release and let a failed publish resume - #13
Merged
Merged
Conversation
The dashboard's assets/package.json links phoenix and LiveView from deps/, so `mix deps.get` has to run before `pnpm install`; the publish job had them the other way round and failed after tagging durable_dashboard-v1.0.0. Running Release again with a version that's tagged but not on Hex now publishes that tag instead of refusing it. "Re-run failed jobs" replays the old workflow file, so it couldn't pick up a fix like this one. Claude-Session: https://claude.ai/code/session_012aEMFtJKJsMz1vGtbSijGR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
durable_dashboard1.0.0 release (run) taggeddurable_dashboard-v1.0.0and committed tomain. It then failed atpnpm install:assets/package.jsonlinksphoenix,phoenix_htmlandphoenix_live_viewfrom../deps/. The publish job ranpnpm installbeforemix deps.get, so those directories didn't exist yet. Regular CI runs them in the right order, which is why it never showed up there.Changes
mix deps.get, then installs the JS deps, then compiles.durable_dashboard/mix.locknow locks durable 1.0.0 from Hex.Checked locally against Hex:
mix deps.getresolves durable 1.0.0,mix compile --warnings-as-errorsis clean, andmix hex.buildbuildsdurable_dashboard1.0.0.actionlintpasses.After merging
Run Release → durable_dashboard → version
1.0.0. It reuses the existing tag and publishes.https://claude.ai/code/session_012aEMFtJKJsMz1vGtbSijGR