Conversation
runtime-sources walked only shared/<arch> and <os>/<arch>, so runnable cases in tests/cases/shared were never selected. Select every suite in target.suites, which already lists shared, shared/<arch>, and <os>/<arch> in that order, and keep the existing native-run filters. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Signed-off-by: LunaStev <luna@lunastev.org>
Signed-off-by: LunaStev <luna@lunastev.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes #691 by preserving its generic
sharedruntime-source selection while excluding the current generic shared runtime cases from WebAssembly targets that cannot execute them with the existing hosts.The original #691 commit and attribution are preserved in this branch.
runtime_sources()iteratingtarget.suites.shared/test1.wavethroughshared/test10.wavefrom the three current WebAssembly targets because those cases useprintlnand requireenv.printf, which the current WebAssembly hosts do not provide.Closes #690.