Align Wave artifacts and harden release acceptance - #155
Merged
Merged
Conversation
Signed-off-by: LunaStev <luna@lunastev.org>
Signed-off-by: LunaStev <luna@lunastev.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Wave compiler artifact selection for Windows MSVC and Linux LoongArch64, require explicit package execution verification, and prevent closed CLI output pipes from causing Rust panics. Strengthen lockfile regression coverage and update release readiness documentation.
Why
Vex still selected a retired Windows GNU compiler archive and rejected two Wave distribution hosts. Packaging could report success after skipping execution verification, and Vex-owned stdout could panic when a pipe consumer exited early.
Behavior
x.py package --allow-unverifiedpermits an absent verifier for development; it never suppresses a failing smoke test and is unavailable tox.py release. Emit a digest-bound JSON verification record per packaged archive.Validation
cargo fmt --checkcargo test --workspace --locked— 135 passed; one ignored subprocess helper is exercised by its parent tests.cargo clippy --workspace --locked --all-targets -- -D warningscargo build --workspace --lockedpython3 x.py checkpassed with installed wavec removed from PATH, VEX_WAVEC unset and an empty managed-toolchain directory; Python suite: 32 passed. Local TCP synchronization fixtures required execution outside the restricted sandbox.cargo check --workspace --tests --locked --target x86_64-pc-windows-gnupassed (cross-compile only, not native Windows execution).Issues
Closes #154
Closes #71
Closes #91
Closes #138
Closes #110
Closes #124
Related acceptance/tracking: #96, #79, #75, #99, #146, #147, #148. Official-release-dependent follow-up: #66, #131. These broader issues are not automatically closed by this PR.
Checklist
wavefnd/Vex:master.--lockedand--offlinebehavior remains correct.wavecflags were added to the Vex CLI.Signed-off-by:line.