[joeywangzr]

Description

Plugin 0.4.3 is available from the canonical Git marketplace. warpdotdev/codex-warp#7 merged on October 14; both the marketplace entry and plugin manifest on main advertise 0.4.3.

Raise the Codex notification-plugin floor to 0.4.3 so cached 0.4.2 installs get upgraded. The companion plugin restores lifecycle delivery from detached Windows hooks; it prevents missing session IDs and completion signals. The orchestration-plugin minimum stays at 0.4.1.

This PR contains only the client version requirement and test changes. Update-behavior coverage remains; there is no constant-only getter test. The transport implementation and Windows integration coverage live in the companion PR.

Linked Issue

• The linked issue is labeled ready-to-spec or ready-to-implement. No dedicated issue is linked; the companion PR carries the fix.
• Where appropriate, screenshots or a short video of the implementation are included below. No GUI change; validation uses isolated console fixtures.

Testing

• I have manually tested my changes locally with ./script/run. Not run; this change only updates the plugin requirement.

Local validation on October 14:

• cargo nextest run -p warp --lib --locked -E 'test(plugin_manager::codex::tests)': 38 passed. Nextest reported one LEAK warning for does_not_support_update_without_codex_plugin; no assertion failed.
• cargo check -p warp --lib --locked: passed.
• cargo clippy -p warp --lib --tests --locked -- -D warnings: passed.
• cargo fmt -p warp and git diff --check: passed.

Existing outdated-cache coverage now uses 0.4.2. The companion's six Windows delivery tests passed on both system ConPTY and Warp's bundled DLL. Post-publication staging E2E validation was not run in this session. Full Warp CI attempt 3 was requested: https://github.com/warpdotdev/warp/actions/runs/37846977663.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Conversation: https://staging.warp.dev/conversation/f70d81ec-85a4-4322-abaf-a1fb9713ce7e
Review follow-up: https://staging.warp.dev/conversation/743855e1-c346-4782-8655-d4e082820056
Plan: https://staging.warp.dev/drive/notebook/sjtUyYQASbuCQEbfYS6AFA

Co-Authored-By: Warp agent@warp.dev

[warp-agent-staging]

@joeywangzr, may varoon's factory diagnose this CI failure, commit fixes, and push to this same PR branch? Yes also opts this PR into automatic handling of future CI failures. Please reply explicitly yes/no and mention @warp-staging-factory; no changes before consent.

Responding as varoon's factory: Open session · View in factory

[warp-for-oss]

@joeywangzr

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-for-oss]

Overview

This PR raises the required Codex notification plugin version from 0.4.2 to 0.4.3 and updates the related unit-test fixture so a cached 0.4.2 install is considered outdated. No approved spec context was provided, and the diff does not add or change comments or security-sensitive code paths.

Concerns

• The attached PR description states that plugin 0.4.3 is not published yet. Raising the client minimum before the companion plugin is available can force update flows to require a version that cannot be installed, so this should remain blocked until the companion release exists.
• The updated minimum-version test now mirrors the implementation constant instead of pinning the expected release floor.

Verdict

Found: 0 critical, 1 important, 1 suggestions

Request changes

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-for-oss]

⚠️ [IMPORTANT] The PR description says 0.4.3 is still unpublished; merging this floor first can make update flows require a plugin version that the marketplace cannot satisfy. Keep this held until the companion plugin release is published.

[warp-for-oss]

💡 [SUGGESTION] This makes the test mirror the implementation constant instead of pinning the release floor; keep the literal version so an accidental minimum bump or downgrade is visible in review.

Suggested change

	MINIMUM_PLUGIN_VERSION
	"0.4.3"

[seemeroland]

Seem valid, but I kind of think this test is useless and we should delete it

[warp-local-for-testing-only]

@joeywangzr, your GitHub account is not connected to Warp. Connect your GitHub account.

[seemeroland]

Approving to unblock but merge the codex plugin pr first

[seemeroland]

Seem valid, but I kind of think this test is useless and we should delete it