Pin winit to X11 request_user_attention panic fix - #15717
Merged
Conversation
Bring in warpdotdev/winit#18 so a dead X11 connection no longer aborts Warp when requesting user attention.
Contributor
Author
|
This PR was generated with Warp. Comment    |
acarl005
marked this pull request as ready for review
September 1, 2026 19:31
acarl005
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin winit to warpdotdev/winit#18 (
14db95a686387211d57cf2afd1d908b2d82a20fe) so X11request_user_attentionno longer panics whenWmHints::setfails on a dead connection.Linked Issue
ready-to-specorready-to-implement.No GitHub issue. Requested after merging the winit fix.
Testing
./script/runMetadata-only pin.
cargo metadata --lockedaccepts the lockfile. On Linux,cargo check -p winit --lockedandcargo check -p warpui --lockedpassed.Agent Mode
CHANGELOG-BUG-FIX: Prevent a crash on Linux/X11 when Warp requests user attention over a dead display connection.